Author Topic: Can we change Co-op a bit?  (Read 16734 times)

Offline QwazyWabbit

  • Carpal Tunnel Member
  • ******
  • Posts: 1371
    • View Profile
  • Rated:
Re: Can we change Co-op a bit?
« Reply #45 on: March 24, 2009, 07:30:45 PM »
yes, removing q2admin gets rid of whatever bugs are in that module but it does nothing for the bugs that exist inside the game dll itself. It just lets you get further into the game where you can work on those uncovered bugs.
  • Insightful
    Informative
    Funny
    Nice Job / Good Work
    Rock On
    Flawless Logic
    Well-Reasoned Argument and/or Conclusion
    Demonstrates Exceptional Knowlege of the Game
    Appears Not to Comprehend Game Fundamentals
    Frag of the Week
    Frag Hall of Fame
    Jump of the Week
    Jump Hall of Fame
    Best Solution
    Wins The Internet
    Whoosh! You done missed the joke thar Cletus!
    Obvious Troll Is Obvious
    DO YOU EVEN LIFT?
    DEMO OR STFU
    Offtopic
    Flamebait
    Redundant
    Factually Challenged
    Preposterously Irrational Arguments
    Blindingly Obvious Logical Fallacies
    Absurd Misconstrual of Scientific Principles or Evidence
    Amazing Conspiracy Theory Bro
    Racist Ignoramus

Offline console

  • Brobdingnagian Member
  • ***
  • Posts: 4518
  • "Man, this is the way to travel," said my attorney
    • View Profile
    • tastyspleen.net
  • Rated:
Re: Can we change Co-op a bit?
« Reply #46 on: March 24, 2009, 08:20:03 PM »
yes, removing q2admin gets rid of whatever bugs are in that module but it does nothing for the bugs that exist inside the game dll itself. It just lets you get further into the game where you can work on those uncovered bugs.

I have to wonder...I'm loathe to defend q2admin much, since its codebase is indeed really crappy.  But on the other hand, q2admin does manage to run without crashing, for _months_, on numerous other mods on servers like vanilla, mutant, dm, railz, xatrix, ra2, sheridan, opentdm, ....

So the fact that coop is still crashing frequently, but less predictably without q2admin in the mix, suggests to me the possibility that the only really important bug we're after exists in the coop code.  If the coop bug is trashing memory, q2admin may just churn the heap more and trigger the crash sooner....

 . . .

I see that there exist patches to create a gcc with a bounds-checking option:

http://williambader.com/bounds/example.html

...hmm, they stopped making patches in 2005, looks like gcc has a builtin "-fbounds-check" flag now...

...GAH!  But the built-in version only supports Java and Fortran.. :raincloud:


Oh well, anyway... One could certainly wrap whatever malloc/free calls are available to the game module with some simple extra data to catch overwrites / underwrites, as well as write some validation routines to walk various internal structures in Q2 to detect whether anything has been obviously stomped on... and do the usual "sprinkle calls to the validation routine throughout the code..."


Regards,

:dohdohdoh:
  • Insightful
    Informative
    Funny
    Nice Job / Good Work
    Rock On
    Flawless Logic
    Well-Reasoned Argument and/or Conclusion
    Demonstrates Exceptional Knowlege of the Game
    Appears Not to Comprehend Game Fundamentals
    Frag of the Week
    Frag Hall of Fame
    Jump of the Week
    Jump Hall of Fame
    Best Solution
    Wins The Internet
    Whoosh! You done missed the joke thar Cletus!
    Obvious Troll Is Obvious
    DO YOU EVEN LIFT?
    DEMO OR STFU
    Offtopic
    Flamebait
    Redundant
    Factually Challenged
    Preposterously Irrational Arguments
    Blindingly Obvious Logical Fallacies
    Absurd Misconstrual of Scientific Principles or Evidence
    Amazing Conspiracy Theory Bro
    Racist Ignoramus

Offline peewee_RotA

  • Brobdingnagian Member
  • ***
  • Posts: 4152
  • Hi, I'm from the gov'ment and I'm here to help you
    • View Profile
  • Rated:
Re: Can we change Co-op a bit?
« Reply #47 on: March 24, 2009, 08:32:17 PM »
This probably sounds stupid but...

Are the additional crashes happening after unit 2? The words "hacky", and "power cube", are pretty much synonymous in the quake 2 code. If it's a memory issue, then it sounds like it has to do with not clearing everything at the end of a unit. The first thing that comes to mind is the fact that keys are handled "differently" in coop. Meaning that things like crosslevel triggers and keys used across a level are probably not cleaned up the same way.
  • Insightful
    Informative
    Funny
    Nice Job / Good Work
    Rock On
    Flawless Logic
    Well-Reasoned Argument and/or Conclusion
    Demonstrates Exceptional Knowlege of the Game
    Appears Not to Comprehend Game Fundamentals
    Frag of the Week
    Frag Hall of Fame
    Jump of the Week
    Jump Hall of Fame
    Best Solution
    Wins The Internet
    Whoosh! You done missed the joke thar Cletus!
    Obvious Troll Is Obvious
    DO YOU EVEN LIFT?
    DEMO OR STFU
    Offtopic
    Flamebait
    Redundant
    Factually Challenged
    Preposterously Irrational Arguments
    Blindingly Obvious Logical Fallacies
    Absurd Misconstrual of Scientific Principles or Evidence
    Amazing Conspiracy Theory Bro
    Racist Ignoramus
GOTO ROTAMODS (rocketgib)
GOTO ROTAMAPS (fireworks)
HappyFriar- q2server.fuzzylogicinc.com
 Tune in to the Tastycast!!!!  http://dna.zeliepa.net

Offline QwazyWabbit

  • Carpal Tunnel Member
  • ******
  • Posts: 1371
    • View Profile
  • Rated:
Re: Can we change Co-op a bit?
« Reply #48 on: March 25, 2009, 12:43:52 PM »
I prefer to debug in VC6's IDE and then deal with GCC after the fact but if there is a decent way to Bcheck the code then I am all for it. I am (slowly) getting better at KDE and GDB.

Regarding malloc, if there are any bare malloc() calls left in your version of q2admin you might want to follow R1ch's Q2 best-practices and always call gi.TagMalloc() from all the game DLL's.

All I know about q2admin is, like you, DM is always stable and I have gotten months of continuous operation of the server without crashes, even cascading GameCam over q2admin over LOX. I don't know what it is about coop but the only way I could get LOX coop to run for very long was to take q2admin out of the picture. GameCam over LOX in coop worked fine, at least in my somewhat limited tests.

Once you have a fairly stable (or even unstable) coop server up and you would like to enable spectator mode you can download a slightly fixed up version of GameCam here: http://www.windowmeister.com/lox (with source) which is the one I use on our LOX server. There was only one bug in Avi's original code where he called gci.dprintf after he had unloaded the dll. :) I think Avi Rozen's code is one of the best examples of Q2 mod coding style out there.

You might be able to spectate WallFly by letting him connect and issue a spectator 1 command to bump him up and out into the gamecam.

Per my earlier post, I found coop (3.21) failing inside q2admin with a smashed user command buffer but I simply don't have time right now to dig into it. I tested it with LOX 1.12.16 with similar results. I would love to be able to fix it once and for all but time is not available to me right now.
  • Insightful
    Informative
    Funny
    Nice Job / Good Work
    Rock On
    Flawless Logic
    Well-Reasoned Argument and/or Conclusion
    Demonstrates Exceptional Knowlege of the Game
    Appears Not to Comprehend Game Fundamentals
    Frag of the Week
    Frag Hall of Fame
    Jump of the Week
    Jump Hall of Fame
    Best Solution
    Wins The Internet
    Whoosh! You done missed the joke thar Cletus!
    Obvious Troll Is Obvious
    DO YOU EVEN LIFT?
    DEMO OR STFU
    Offtopic
    Flamebait
    Redundant
    Factually Challenged
    Preposterously Irrational Arguments
    Blindingly Obvious Logical Fallacies
    Absurd Misconstrual of Scientific Principles or Evidence
    Amazing Conspiracy Theory Bro
    Racist Ignoramus

 

El Box de Shoutamente

Last 10 Shouts:

 

|iR|Focalor

November 06, 2024, 03:28:50 AM
 

RailWolf

November 05, 2024, 03:13:44 PM
Nice :)

Tom Servo

November 04, 2024, 05:05:24 PM
The Joe Rogan Experience episode 223 that dropped a couple hours ago with Musk, they're talking about Quake lol.
 

Costigan_Q2

November 04, 2024, 03:37:55 PM
Stay cozy folks.

Everything is gonna be fine.
 

|iR|Focalor

October 31, 2024, 08:56:37 PM
 

Costigan_Q2

October 17, 2024, 06:31:53 PM
Not activated your account yet?

Activate it now! join in the fun!

Tom Servo

October 11, 2024, 03:35:36 PM
HAHAHAHAHAHA
 

|iR|Focalor

October 10, 2024, 12:19:41 PM
I don't worship the devil. Jesus is Lord, friend. He died for your sins. He will forgive you if you just ask.
 

rikwad

October 09, 2024, 07:57:21 PM
Sorry, I couldn't resist my inner asshole.
 

Costigan_Q2

October 09, 2024, 01:35:05 PM
Et tu rikwad?

Please don't feed the degenerate lies of a sexually-perverted devil-worshipping barking dog like Focalor.

Show 50 latest
Welcome, Guest. Please login or register.
November 09, 2024, 10:46:18 PM

Login with username, password and session length