You can't see me. HAVE YOU SEEN ME???

[console]

GREETINGS AND SALUTATIONS,

r1ch may have found the longstanding "INVISIBILITY BUG".

Apparently id Software goofed on their 3.21 source release, and re-introduced a bug they had previously fixed.

In p_client.c: PutClientInServer()

Code: [Select]

--- game/p_client.c     11 May 2005 03:21:23 -0000   1.4
+++ game/p_client.c     3 Oct 2006 15:32:11 -0000
@@ -1188,7 +1188,7 @@
        ent->waterlevel = 0;
        ent->watertype = 0;
        ent->flags &= ~FL_NO_KNOCKBACK;
-       ent->svflags &= ~SVF_DEADMONSTER;
+       ent->svflags = 0;  // invisiblilty fix (id apparently lost this between 3.20 and 3.21)

        VectorCopy (mins, ent->mins);
        VectorCopy (maxs, ent->maxs);

So r1ch has provided me a simple patch (above) to restore the original id Software fix as of 3.20, that somehow regressed to being broken in 3.21.

So please be on the lookout for the invisibility bug, if you play on the following servers: vanilla, vanilla2, dm, mutant, pygmy, xquake, ts500.  Hopefully the problem is now fixed.  If not, please let me know.

(NOTE: The patch has not been applied to the sheridan code yet, so, invisibility could still happen there.)


Thanks,

[Whirlingdervish]

Nice work R1CH! (and quadz!  )

 

[jägermonsta]

(NOTE: The patch has not been applied to the sheridan code yet, so, invisibility could still happen there.)

Get to work Wheet!   

[[BTF]Jehar]

Awesome!!! It does cause me to wonder what could have caused that to get lost though. Perhaps some side bug that somebody figured was worth risking invisibility? It's not Carmacks work, that's for sure.

This does save some annoyance though, thank you.

[Punk_FAS]

Nice work 

[Wheet]

Sheridan is now up to date, just needs to go live. I would assume it's the SVF_NOCLIENT which is causing the problem if this solution holds true, probably somehow this flag is not being unset on a player leaving the game from spectator mode? It could be when they re-enter the server they inherit the SVF_NOCLIENT flag from their last play. I would think the edict structure would be freed from memory after the client is disconnected but maybe not. It would seem odd, however, that since PutClientInServer() is called on the first spawn and all respawns that the inviso bug clears up when the player is killed. Unless somewhere in the death sequence the SVF_NOCLIENT or all edict server flags are cleared. I also enjoy all you can eat pancakes, I can never eat too many though, those suckers fill you up fast.

[Wheet]

I am going to update Sheridan with the following patch:

p_client.c

void ClientBeginDeathmatch (edict_t *ent)
{
        G_InitEdict (ent);

        InitClientResp (ent->client);

        // locate ent at a spawn point
+      ent->svflags &= ~SVF_NOCLIENT;
        PutClientInServer (ent);


I am almost positive that this will fix the problem without forcing the PutClientInServer to clear svflags on the edict. I don't know if it will ever be a problem that it clears the flags but just incase it is I would rather not cause another bug. Please update live Sheridan with this new change.

[console]

Sheridan is now up to date, just needs to go live. I would assume it's the SVF_NOCLIENT which is causing the problem if this solution holds true, probably somehow this flag is not being unset on a player leaving the game from spectator mode?

Thanks!  Sheridan is updated/restarted.

Yes, in fact that's how r1ch deliberately reproduced the bug...

[20:43] <R1CH> well
[20:43] <R1CH> i reproduced it as expected first time on ts500
[20:44] <quadz> whoa... how ? 
[20:44] <R1CH> re-use of spectator slot which disconnected during free float cam

Regards,

quadz

[console]

I am going to update Sheridan with the following patch:

p_client.c

void ClientBeginDeathmatch (edict_t *ent)
{
        G_InitEdict (ent);

        InitClientResp (ent->client);

        // locate ent at a spawn point
+      ent->svflags &= ~SVF_NOCLIENT;
        PutClientInServer (ent);


I am almost positive that this will fix the problem without forcing the PutClientInServer to clear svflags on the edict. I don't know if it will ever be a problem that it clears the flags but just incase it is I would rather not cause another bug. Please update live Sheridan again unless you haven't done it yet.

Well, actually this was the very first patch r1ch suggested... (with the caveat that he took no responsibility if spectators suddenly became visible ).

However, when he compared against the older id sources, which show that idsoftware's own fix was the "ent->svflags = 0" in PutClientInServer, we undid the change you suggested above, and just went with id's solution.


Regards,

quadz

[X'tyfe]

this is good news indeed 

[Wheet]

I am positive that my change will not make spectators appear during spectator mode. I suppose id threw that in PutClientInServer() just incase they missed any other logical AND operations to clear certain svflags; just to be on the safe side. If they chose that method though it's most likely legit. If BFGs start falling from the sky and white rabbits start hopping around on Sheridan we will know why. 

[[BTF] Reflex]

BUNNIES!!!!!!!!!



hah,  its all fixed...  and I dont think AX will be around to enjoy it??????????

[Whirlingdervish]

Axe is busy bitching about spammers now that they've fixed this "terrible injustice".
I guess someone has to be the voice of completely selfish assholism even when things are getting fixed,
Otherwise that lazy quadz guy might never do anything around here!
 

[Sgt. Dick]

Damn,

I was only invisible once during all this time, and now its gone 

Good work since it happen alot more against me than for me