Sounds bug (player sounds not playing)

[Slayer :D]

How do I make a player whose sounds I do not have (e.g. he is using a skin called "asdasd/sfdsdf") make typical male sounds? When you shoot people, the sound generated is linked to players/<model_name>/pain#_#.wav. However, if you do not have the model (as in the above example of "asdasd"), you cannot hear the sounds. How do I force any non-male or female players to use the default player sounds.

edit: I checked more and it only occurs if you do not have the player model; if he uses male/qwerty you still hear the sounds. Also, I tested with s_show "1" and it shows that the players/<any_unknown_model>/<any_sound>.wav does not play; including falling sounds.

[ReCycled]

By default it should go to the set of male/grunt sounds. You don't have to do anything. I've never seen this issue with sound in Q2. Do other sounds play (wav, mp3 etc)?

[Slayer :D]

I found out what it is: a bug with the R1Q2 OpenAL sound loading code (default sound code works fine).

In S_OpenAL_LoadSound(sfx_t *sfx), there is the following code to load the sound:

// Load it from disk
if (sfx->name[0] == '#')
   Com_sprintf(name, sizeof(name), "%s", &sfx->name[1]);
else
   Com_sprintf(name, sizeof(name), "sound/%s", sfx->name);

if (!S_OpenAL_LoadWAV(name, &data, &info))
{
   Com_DPrintf ("WARNING: couldn't find sound '%s'\n", name);
   return false;
   //S_CreateDefaultSound(&data, &info);
}

This will only load players/model_name/xxxx.wav.
I tested this by replacing the "return false" with the following:

Code: [Select]

// Declarations at beginning of methodfor new local variables
char *slash1;
char *slash2;
char temp2[MAX_QPATH];



// begin patch code...
if(sfx->name[0] == '#')
{
// gets the slashes, and does some bug checking
slash1 = strchr(name, '/');
if(!slash1)
{
Com_Printf("WARNING: Could not find 1st '/'! Sound name: %s\n", LOG_CLIENT, name);
return false;
}
else if(name[(int)(slash1-name)+1] == 0)
{
Com_Printf("WARNING: Zero byte encountered after 1st '/'! Sound name: %s\n", LOG_CLIENT, name);
return false;
}
slash2 = strchr(slash1+1, '/');
if(!slash2)
{
Com_Printf("WARNING: Could not find 2nd '/'! Sound name: %s\n", LOG_CLIENT, name);
return false;
}
else if(name[(int)(slash2-name)+1] == 0)
{
Com_Printf("WARNING: Zero byte encountered after 2nd '/'! Sound name: %s\n", LOG_CLIENT, name);
return false;
}
// save the data
strcpy(temp2, slash2+1);
// expand to "players" directory...
Com_sprintf(name, sizeof(name), "players/male/%s", temp2);
// try loading that
if (!S_OpenAL_LoadWAV(name, &data, &info)) return false;
}
else return false;
// end patch

This, if it cannot find the players/model_name/xxx.wav looks for players/male/xxx.wav. I suppose I could do what default sound code does which is load from sound/player/male/xxx.wav by replacing the "players/male/%s" with "sound/player/male/%s", but I prefer to load from the players directory. I am also not certain if strchr will buffer overrun if you give it a pointer to the 0x00 string terminator byte, so it might be possible to remove the two checks for zero bytes.